Skip to content

Query doesn't complete #292

Closed
Closed
@mosherobinov

Description

@mosherobinov

Bug Report

Versions

  • Driver: 0.8.4.BUILD-SNAPSHOT
  • Database: PostgreSQL 12
  • Java: 1.8.0_202
  • OS: macOS Catalina 10.15.5

Current Behavior

query doesn't complete and doesn't emit all of the rows.

Steps to reproduce

i forked r2dbc-postgresql and added a new test that reproduce this issue.
take a look at this commit: mosherobinov@a679e8e
seems to be some kind of a race between the onNext() and request() when they are happening on different threads,
therefore i had to publish on a different scheduler and limitRate to 1 so the onNext() and request() will interleave.
the test times out after the query doesn't complete.

Activity

x0a1b

x0a1b commented on Jun 25, 2020

@x0a1b

I can confirm this happening; this fix should be part of 0.8.4.RELEASE build.

added this to the 0.8.4.RELEASE milestone on Jun 26, 2020
mp911de

mp911de commented on Jun 26, 2020

@mp911de
Collaborator

Thanks a lot for the reproducer. I'm going to investigate what's going on.

mp911de

mp911de commented on Jun 26, 2020

@mp911de
Collaborator

As it looks now, the emission gets stuck after request(1). This is, because of missing upstream demand propagation (hasBufferedItems() && hasDownstreamDemand() doesn't allow entering drainLoop). Calling demandMore() helps to address the issue. Need to check whether that's the fix or whether we might miss something.

added 3 commits that reference this issue on Jun 26, 2020
added
type: regressionA regression from a previous release
and removed
status: in-progressAn issue that is currently being worked on
on Jun 26, 2020

12 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mp911de@mosherobinov@x0a1b

        Issue actions

          Query doesn't complete · Issue #292 · pgjdbc/r2dbc-postgresql