Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed all external resources locally instead of using a CDN #2099

Closed
hadley opened this issue May 31, 2022 · 0 comments · Fixed by #2249
Closed

Embed all external resources locally instead of using a CDN #2099

hadley opened this issue May 31, 2022 · 0 comments · Fixed by #2249
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues
Milestone
2.1.0

Comments

@hadley
Copy link
Member

hadley commented May 31, 2022

Since CDN's are no longer useful for shared resources: https://www.stefanjudis.com/notes/say-goodbye-to-resource-caching-across-sites-and-domains/
@hadley hadley mentioned this issue May 31, 2022
Closed
@hadley hadley added feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues labels May 31, 2022
@maelle maelle mentioned this issue Jun 2, 2022
Closed
@salim-b salim-b mentioned this issue Dec 5, 2022
Merged
@maelle maelle mentioned this issue Mar 20, 2023
Closed
@hadley hadley added this to the 2.1.0 milestone Apr 12, 2024
hadley added a commit that referenced this issue May 28, 2024
@salim-b @hadley
Avoid exernal assets (#2249)
3751893 
Now turn them into HTML dependencies objects, caching them in the user cache directory. Fixes #2099.
---------

Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
@salim-b @hadley @SebKrantz
Avoid exernal assets (r-lib#2249)
ba79068 
Now turn them into HTML dependencies objects, caching them in the user cache directory. Fixes r-lib#2099.
---------

Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Avoid exernal assets salim-b/pkgdown
1 participant
@hadley