Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with load progress indicator / Current URL is invalid! #2176

Open
lahwaacz opened this issue Dec 16, 2016 · 7 comments
Open

Issues with load progress indicator / Current URL is invalid! #2176

lahwaacz opened this issue Dec 16, 2016 · 7 comments
Labels
priority: 1 - middle Issues which should be done at some point, but aren't that important.

Comments

@lahwaacz
Copy link
Contributor

There are multiple issues with the load progress indicator when the network connection is not ideal:

  • The URL for the tab is not updated until the server responds and the page starts loading (or the connection timeout expires). Until that happens, you can't yank the new URL (obviously) and closing the browser leads to loss of information. This happens with both the QtWebEngine and QtWebKit backends.
  • With QtWebEngine, the load progress indicator in statusbar does not appear until the server responds, so it is rather tricky for the user to conclude that something is wrong with the connection and not the browser.
@lahwaacz
Copy link
Contributor Author

Oh, the progress bar might actually be there, since the [top] [<tab>/<ntabs>] part is shifted to the left, but stuck at 0% which makes it completely invisible... Apparently QtWebKit always sets it to a positive value so it's visible. In any case, IMO a textual description like [Loading 0%] would be nicer for this corner case.

@tbodt
Copy link

tbodt commented Dec 16, 2016

It is true that there's a percent indicator in the title bar, but when I have qutebrowser in OSX full screen the title bar is invisible.

@lahwaacz
Copy link
Contributor Author

lahwaacz commented Dec 17, 2016

I guess I could configure tabs.title-format to include {perc} as the first item, but it seems odd to me to provide status information in the tab (or window) title rather than in the statusbar.

@The-Compiler The-Compiler added the priority: 1 - middle Issues which should be done at some point, but aren't that important. label Dec 19, 2016
@haasn
Copy link
Contributor

haasn commented Apr 21, 2017

cc @annulen re: URL not being returned by qtwebkit until the page either loads or times out

10:11 <haasn> it's just in this metaphysical state between clicking on a link and that link timing out that the current URL is invalid
10:14 <haasn> It also doesn't work for other things involving the page URL
10:15 <haasn> for example yanking, opening in an external program, or downloading
10:20 <The-Compiler> haasn: probably because Qt has emitted loadingStarted at some point, but still returns an invalid URL when asked what URL it is
10:20 <haasn> so you're suggesting this is a qtwebkit-internal behavior/issue?
10:22 <The-Compiler> well, qutebrowser could work around it, but I'd prefer if QtWebKit/QtWebEngine would handle it properly
10:22 <The-Compiler> there's a qutebrowser issue for it somewhere
10:24 <The-Compiler> https://github.com/qutebrowser/qutebrowser/issues/2176

@blueyed
Copy link
Contributor

blueyed commented Sep 17, 2018

I am also seeing the "Current URL is invalid!" error when trying something like gu or go on a page that is still loading.
qutebrowser should be able to set the URL internally already I would assume.

@The-Compiler
Copy link
Member

FWIW a good test case for the "Current URL is invalid!" error is https://www.google.com/csi which returns HTTP/1.1 204 No Content.

@VehementHam
Copy link

#5359 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 1 - middle Issues which should be done at some point, but aren't that important.
Projects
None yet
Development

No branches or pull requests

6 participants