Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible ambiguous saved scenario history #1320

Closed
robcalon opened this issue Jan 31, 2023 · 4 comments
Closed

Possible ambiguous saved scenario history #1320

robcalon opened this issue Jan 31, 2023 · 4 comments
Assignees
Labels
Pinned Will never be marked as stale or auto-closed.

Comments

@robcalon
Copy link

It is possible to edit a scenario_id that's part of a saved scenario's history and set that scenario_id as the 'active' scenario when loading a saved scenario. In this case the scenario_id will be both in the scenario history as being the active scenario in the returned information.

Once I again update the saved scenario by referring to a new scenario_id, the scenario_id that was already present in the history will not change position in the scenario_id_history list. I would have expected that the order of the scenario_id_history list would at least have changed, making the history a bit ambiguous.

I would expect the API to refuse setting to update an saved scenario with a scenario_id that is already present in the scenario_id_history to prevent this behaviour from happing. You could than revert your scenario to an point in time by setting a copy of the point in time as the active scenario_id.

@github-actions
Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Apr 23, 2023
@github-actions github-actions bot closed this as completed May 1, 2023
@robcalon
Copy link
Author

robcalon commented May 1, 2023

@noracato is this one to reopen or is this addressed elsewhere?

@noracato noracato reopened this May 3, 2023
@noracato noracato removed the Stale Issue had no activity for 60 days and will be, or has been, closed. label May 3, 2023
@noracato
Copy link
Member

noracato commented May 3, 2023

Yes, it closed itself while I was on holiday 😄

@noracato
Copy link
Member

Fix is now live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants