Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of old cost calculation method #1239

Open
lottevanvlimmeren opened this issue Mar 24, 2022 · 3 comments
Open

Cleanup of old cost calculation method #1239

lottevanvlimmeren opened this issue Mar 24, 2022 · 3 comments
Assignees
Labels
effort:3 Pinned Will never be marked as stale or auto-closed.

Comments

@lottevanvlimmeren
Copy link
Contributor

During the cost update project, a new method for cost calculation has been written. The new method does not use the fixed and variable costs anymore, but considers the CAPEX and OPEX. Part of the old method is still included in the code (/app/models/qernel/node_api/cost.rb), and should be cleaned up. The old total cost calculation should especially be removed, since this does not reflect on the new total costs anymore.

image

When the total cost calculation is removed from the file, and the energy graph is opened locally, error messages show up in the node information. This should be updated as well.

image

Notifying @DorinevanderVlies

@github-actions
Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Jun 19, 2022
@ChaelKruip ChaelKruip added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Jun 20, 2022
@DorinevanderVlies
Copy link
Contributor

@noracato this is finished right?

@noracato
Copy link
Member

Unfortunately no. I keep on hitting roadblocks: many of the merit order calculations rely on the methods we wanted to remove because they were deemed redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:3 Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants