Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Tokio 0.3 #872

Closed
SriRamanujam opened this issue Oct 16, 2020 · 10 comments
Closed

Update to Tokio 0.3 #872

SriRamanujam opened this issue Oct 16, 2020 · 10 comments

Comments

@SriRamanujam
Copy link

No description provided.

@djc
Copy link
Collaborator

djc commented Oct 17, 2020

The AsyncFd PR is here: tokio-rs/tokio#2903. I think we need to implement our UDP wrapper. It also looks like the 0.7 mio UdpSocket has lost its only_v6() method, so we have to get that reimplemented upstream or figure out some other way to detect dual-stack sockets.

@djc
Copy link
Collaborator

djc commented Oct 17, 2020

(I have been discussing with an Apple engineer from the quicdev Slack whether there's a better way to do things on Darwin or whether there's a bug on their side, I'll see what I can get out of that.)

@djc
Copy link
Collaborator

djc commented Oct 17, 2020

Very WIP PR in #873.

@Ralith
Copy link
Collaborator

Ralith commented Oct 18, 2020

I'm concerned that the move to AsyncFd doesn't give us a way forward for specialized UDP operations on non-Unix platforms.

@djc
Copy link
Collaborator

djc commented Oct 18, 2020

They're open to feedback on the PR, I think.

@Darksonn
Copy link

We are very open to feedback on the best way forward. The reason it didn't make it for 0.3.0 was unanswered questions on the best way to design it.

@Ralith
Copy link
Collaborator

Ralith commented Oct 21, 2020

Discussion on the Tokio discord revealed that we don't actually have the capacity for specialized UDP operations outside Unix on 0.2 either, so we're good to proceed once AsyncFd or equivalent is in.

@Ralith
Copy link
Collaborator

Ralith commented Oct 25, 2020

See also tokio-rs/tokio#2968.

@Darksonn
Copy link

We have released AsyncFd.

@djc
Copy link
Collaborator

djc commented Dec 27, 2020

Let's use #856 for this.

@djc djc closed this as completed Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants