Outgoing ACK improvements #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application datagrams may be too large to fit into a packet with ACKs present. Therefore, if we have unsent ACKs, doing so may push a queued application datagram into the next packet. If no other data is queued, the first packet will then be ACK-only. Sending an ACK-only packet without having received an ACK-eliciting packet following our last ACK-only packet is illegal, and will trigger a debug assert. By being slightly less enthusiastic about sending ACKs, we ensure that any inadvertently generated ACK-only packet is legal and simplify our logic slightly. This approach also seems to be popular with other implementations, as indicated by ad-hoc feedback on the slack.
As recommended in RFC 9000 §13.2.4. Simplifies sent packet state and acknowledgement processing.
djc
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1413.