Named futures + replace NewConnection with Connection methods #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
changed the title
Closed
djc
reviewed
May 23, 2022
|
Sorry for the slow review... |
|
No worries; it's not particularly pressing, nor a rebase hazard. |
Merged
7 tasks
Ralith
force-pushed
the
named-futures
branch
2 times, most recently
from
9db0829
to
df65cd7
Compare
Ralith
force-pushed
the
named-futures
branch
from
df65cd7
to
399c595
Compare
|
Still TODO: Actually getting rid of |
|
That seems to have panned out to a pleasant simplification in the tests/examples. Less |
Ralith
force-pushed
the
named-futures
branch
5 times, most recently
from
199c724
to
6f4a7be
Compare
djc
reviewed
Sep 20, 2022
Ralith
force-pushed
the
named-futures
branch
2 times, most recently
from
f5fe239
to
2ee0aa4
Compare
Reduces indirection and allows us to avoid cloning an `Arc` each time one of the relevant events is waited on, and opens the door to handwritten futures built on them.
Ralith
force-pushed
the
named-futures
branch
from
2ee0aa4
to
a08c060
Compare
15 tasks
kpp
reviewed
Sep 21, 2022
Provides a more natural alternative to the streams in NewConnection
Ralith
force-pushed
the
named-futures
branch
from
a08c060
to
4fc71b6
Compare
djc
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with a return to named 'static futures, motivated by downstream use cases. See e.g. hyperium/h3#80.
Open questions:
Also included is an idea to drop
NewConnectionin favor of unobtrusive async methods onConnection, bundled because they would have to be rewritten to match this PR's approach if it move forwards. I'd like feedback on this change before I invest the effort to actually removeNewConnectionand update all the examples/docs.