Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection: change overly verbose info span to debug #1351

Merged
merged 1 commit into from May 5, 2022

Conversation

alessandrod
Copy link
Contributor

This moves a super verbose info span to debug. In addition to reducing clutter, it turns out that when running with RUST_LOG=info, this span actually takes significant cpu time

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this has ever proved to be useful in practice; I honestly wouldn't mind stripping it out entirely.

@djc djc merged commit dfa4f0e into quinn-rs:main May 5, 2022
@philpax
Copy link

philpax commented Aug 22, 2022

This is quite spammy; I've sidestepped it by lowering Quinn's warning level in my RUST_LOG, but I'd prefer not to do that. Are there any plans to release a 0.8.x with this fix?

@djc
Copy link
Collaborator

djc commented Aug 22, 2022

Please submit a PR that backports this change to 0.8, and add a separate commit that bumps the version number for the relevant crate(s), and we will be happy to publish it to crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants