Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry token fixes #1332

Merged
merged 6 commits into from Mar 30, 2022
Merged

Retry token fixes #1332

merged 6 commits into from Mar 30, 2022

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Mar 25, 2022

Resolves some correctness issues detected in interop testing, and makes us a bit better at detecting them ourselves.

@Ralith Ralith force-pushed the retry-token-fixes branch 2 times, most recently from 35734a5 to ae0ce6c Compare March 25, 2022 19:32
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by all this. This seems to replace Options with empty byte sequences all over the place, which doesn't seem like an improvement, especially when we just add comments saying they're always empty for clients.

quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
djc
djc previously approved these changes Mar 30, 2022
@djc djc merged commit 6fc46ae into main Mar 30, 2022
@djc djc deleted the retry-token-fixes branch March 30, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants