Strip down futures-* dependencies #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
optional-futures
branch
from
ed2b58b
to
f7f6c6b
Compare
This was calling `Endpoint::connect_with` outside of a tokio runtime context.
We're already using tokio::sync for Notify, so this drops a dep for free.
Establishes symmetry with our other async streams, making it usable without importing a trait from futures-core.
This was only used to implement Stream, which we don't actually need.
This wasn't serving any purpose we couldn't more readably accomplish with async/await.
Ralith
force-pushed
the
optional-futures
branch
from
f7f6c6b
to
96526a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops 6 packages from the workspace-scoped Cargo.lock, and should save a decent amount of buildtime, both locally and downstream.