Replace futures-util with optional futures-io dep #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's simple enough to Pin::new ourselves.
It's simple enough to Pin::new ourselves.
This is our last hard dep on futures_util, and not too difficult to do by hand.
Ralith
force-pushed
the
inherent-next
branch
from
930b02a
to
f0215e2
Compare
|
This also improves consistency with tokio primitives, e.g. |
Ralith
force-pushed
the
inherent-next
branch
2 times, most recently
from
a3316d1
to
0076dbb
Compare
|
Should we use futures-io as the optional dep rather than futures-util? Otherwise this looks great! |
Ralith
force-pushed
the
inherent-next
branch
from
0076dbb
to
2953454
Compare
Allows for convenient use in async blocks by downstream code without a futures_util dependency.
Ralith
force-pushed
the
inherent-next
branch
from
2953454
to
3e3fd27
Compare
|
Good catch, I didn't know that crate existed! Fixed. |
Ralith
changed the title
djc
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial amount of additional code lets us save another dep and be a bit more accessible to new users (see e.g. #1262).