Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Trait is not externally implementable anymore #1242

Closed
BiagioFesta opened this issue Nov 18, 2021 · 3 comments
Closed

Controller Trait is not externally implementable anymore #1242

BiagioFesta opened this issue Nov 18, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@BiagioFesta
Copy link
Contributor

With the new release 0.8.0, the trait Controller cannot be implemented (e.g. a custom congestion controller) because the method on_ack requires RttEstimator which seems to not be pub re-exported.

Or am I missing something? (in that case I apologize for my laziness in not had a deeper check and I am going to immediately close this issue).

The trait and the library design with dyn polymorphism seems to encourage the possibility to implement a custom cc.
Considering this was allowed before and I don't find any relevant in the release notes.

Waiting for feedback. If needed, I will be glad to open a small PR to fix this.

@djc
Copy link
Collaborator

djc commented Nov 18, 2021

Yes, I think this is just an oversight and we should make RttEstimator public.

@Ralith
Copy link
Collaborator

Ralith commented Nov 18, 2021

Thanks for catching this; a PR would be very welcome!

@Ralith
Copy link
Collaborator

Ralith commented Nov 20, 2021

Fixed by #1243.

@Ralith Ralith closed this as completed Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants