Fix inline embed insertions with applyDelta() #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
commented
Jun 6, 2023
core/editor.ts
Outdated
| const [leaf] = this.scroll.leaf(index); | ||
| const formats = merge({}, bubbleFormats(leaf)); | ||
| // @ts-expect-error | ||
| const [leaf] = this.scroll.descendant(LeafBlot, index); |
There was a problem hiding this comment.
For <p>a<strong>b</strong></p>, this.scroll.leaf(1) returns "a" whereas this.scroll.descendant(LeafBlot, index) returns "b". The latter represents the target position of the insert so changing to that.
luin
force-pushed
the
zh-inline-embed-bug
branch
3 times, most recently
from
92a090c
to
ded4666
Compare
jhchen
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed two bugs related to inserting inline embeds caught by #3789. See test cases and comments for details.