Fix max bucket limit in histogram #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max bucket limit in histogram was broken, since some code introduced temporary filtering of buckets, which then resulted into an incorrect increment on the bucket count. The provided solution covers more scenarios, but there are still some scenarios unhandled (See #1702).
PSeitz
force-pushed
the
histogram_max_bucket
branch
from
9c46587
to
bad4d34
Compare
fulmicoton
approved these changes
Dec 12, 2022
fulmicoton
reviewed
Dec 12, 2022
fulmicoton
reviewed
Dec 12, 2022
fulmicoton
reviewed
Dec 12, 2022
| .iter() | ||
| .take_while(|bucket| bucket.doc_count <= self.min_doc_count) | ||
| .count(); | ||
| let cut_off_buckets_end = self |
There was a problem hiding this comment.
nitpick... The opposite of front is back.
Suggested change
| let cut_off_buckets_end = self | |
| let cut_off_buckets_back = self |
fulmicoton
reviewed
Dec 12, 2022
fulmicoton
reviewed
Dec 12, 2022
PSeitz
force-pushed
the
histogram_max_bucket
branch
from
080fb26
to
a90810c
Compare
Co-authored-by: Paul Masurel <paul@quickwit.io>
PSeitz
force-pushed
the
histogram_max_bucket
branch
from
a90810c
to
644a8b2
Compare
fulmicoton
approved these changes
Dec 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
+ Coverage 94.06% 94.11% +0.04%
==========================================
Files 259 261 +2
Lines 49637 50009 +372
==========================================
+ Hits 46692 47066 +374
+ Misses 2945 2943 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Jan 13, 2023
Closed
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
* Fix max bucket limit in histogram The max bucket limit in histogram was broken, since some code introduced temporary filtering of buckets, which then resulted into an incorrect increment on the bucket count. The provided solution covers more scenarios, but there are still some scenarios unhandled (See quickwit-oss#1702). * Apply suggestions from code review Co-authored-by: Paul Masurel <paul@quickwit.io> Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max bucket limit in histogram was broken, since some code introduced temporary filtering of buckets, which then resulted in an incorrect increment on the bucket count.
The provided solution handles more use cases correctly, but there are still some scenarios unhandled (See #1702).
quickwit-oss/quickwit#2503