Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No fsync on atomic_write #1224

Closed
fulmicoton opened this issue Dec 2, 2021 · 0 comments
Closed

No fsync on atomic_write #1224

fulmicoton opened this issue Dec 2, 2021 · 0 comments

Comments

@fulmicoton
Copy link
Collaborator

I thought tempfile::persist was taking in charge to fsync, but it is not.
Today, no fsync is not happening on atomic_write.
fulmicoton added a commit to lpouget/tantivy that referenced this issue Dec 10, 2021
@fulmicoton
Bugfix: adds missing fdatasync on atomic_write.
5293dd8 
In addition this PR:
- removes unnecessary flushes and fsyncs on files.
- replace all fsync by fdatasync. The latter triggers
a meta sync if a metadata required to read the file
has changed. It is therefore sufficient for us.

Closes quickwit-oss#1224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fulmicoton