You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating an histogram bucket it is quite easy to shoot oneself in the foot.
We could have a parameter (not sure what would be a good name) to return an error if there are too many results.
The idea is just not to crash the server.
(The min_count can then easily fix the user problem)
We can default to 1000 (?)
The text was updated successfully, but these errors were encountered:
We already a max bucket limit (quickwit-oss/tantivy#1363) and it's set to 65000. const AGGREGATION_BUCKET_LIMIT: u32 = 65000;
Currently histogram buckets are pre-created depending on the fastfields min max values and passed bounds. This allows easy computation of the bucket pos for incoming values.
When we would enable the bucket limit during initial bucket creation a lot of valid queries would be cancelled, so the validation is postponed for the conversion to intermediate buckets.
We need to switch the Histogram to lazy bucket creation to enable a more early cancellation.
Edit: There seems to be a regression, there's an incorrect validation when converting to intermediate buckets.
When creating an histogram bucket it is quite easy to shoot oneself in the foot.
We could have a parameter (not sure what would be a good name) to return an error if there are too many results.
The idea is just not to crash the server.
(The min_count can then easily fix the user problem)
We can default to 1000 (?)
The text was updated successfully, but these errors were encountered: