Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obscure error on key update with quinn server #279

Open
Ralith opened this issue Jan 22, 2022 · 3 comments · May be fixed by #280
Open

Obscure error on key update with quinn server #279

Ralith opened this issue Jan 22, 2022 · 3 comments · May be fixed by #280

Comments

@Ralith
Copy link
Contributor

Ralith commented Jan 22, 2022

When Quinn is the server, the key update test always seems to fail here:

https://github.com/marten-seemann/quic-interop-runner/blob/86f5d35e7b9d21c9e6e71075ab0ccf33f41d734e/testcases.py#L914-L918

The key log file is certainly present and looks sane, and it seems like the download is completing properly. Would it be possible to log the actual error here?
@marten-seemann
Copy link
Collaborator

Sure, why not? Want to submit a patch?

@Ralith
Copy link
Contributor Author

Ralith commented Jan 24, 2022

I don't have much grasp of this project/python in general and I can't get it to run locally (some network issue makes every test time out), but I guess I can try the obvious.

@Ralith Ralith linked a pull request Jan 24, 2022 that will close this issue
Open
@marten-seemann
Copy link
Collaborator

This is the error:

Traceback (most recent call last):
  File "/Users/marten/src/quic-interop-runner/testcases.py", line 928, in check
    client[1 if p.key_phase == "True" else 0] += 1
                ^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pyshark/packet/layers/xml_layer.py", line 79, in __getattr__
    raise AttributeError()
AttributeError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log key phase read error details Ralith/quic-interop-runner
2 participants
@Ralith @marten-seemann