Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruleguard doesn't work on go 1.18 #380

Closed
bmhatfield opened this issue Mar 16, 2022 · 3 comments · Fixed by #381
Closed

Ruleguard doesn't work on go 1.18 #380

bmhatfield opened this issue Mar 16, 2022 · 3 comments · Fixed by #381

Comments

@bmhatfield
Copy link

I'm receiving errors like:

package "sort" without types was imported from "net".

This appears to be a resolved issue in newer versions of golang.org/x/tools: see this issue comment for more.

@quasilyte
Copy link
Owner

Could you check it again and confirm whether #381 fixes the problem?

@bmhatfield
Copy link
Author

Oh! I'm so sorry - you closed this almost right away and I did not notice. Yes! Confirmed that ruleguard works on 1.18 for me as of 7750682a489adc9ed7c739b87a8324315bb7b930. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@bmhatfield @quasilyte and others