Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruleguard: call Walk handler with nodetag #341

Merged
merged 1 commit into from Jan 2, 2022

Conversation

quasilyte
Copy link
Owner

This allows us to get rid of nodetag.FromNode() call per
every ast node being processed.

name         old time/op  new time/op  delta
EngineRun-8  94.8µs ± 1%  82.8µs ± 0%  -12.70%  (p=0.000 n=10+8)

This allows us to get rid of `nodetag.FromNode()` call per
every ast node being processed.

	name         old time/op  new time/op  delta
	EngineRun-8  94.8µs ± 1%  82.8µs ± 0%  -12.70%  (p=0.000 n=10+8)
@quasilyte quasilyte merged commit 0a106b4 into master Jan 2, 2022
@quasilyte quasilyte deleted the quasilyte/astwalk_with_nodetag branch January 2, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant