ruleguard,analyzer: change Report() callback argument #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasilyte
force-pushed
the
quasilyte/rework_report_arg
branch
from
fbb8806
to
027a675
Compare
Pass a structure with a set of fields instead of passing them as separate arguments. This makes it easier to add more (potentially experimental) match context arguments without breaking the API. But this time we have to break the API once.
quasilyte
force-pushed
the
quasilyte/rework_report_arg
branch
from
027a675
to
5bbdc5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a structure with a set of fields instead of
passing them as separate arguments.
This makes it easier to add more (potentially experimental)
match context arguments without breaking the API.
But this time we have to break the API once.
AST walker now saves current function name (and type name if it's
a method). This can be useful in filters later, so we can match
the current function name/type in
Where()expressions.