Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should const $x = $y match const ($x = $y) and vice versa? #295

Open
quasilyte opened this issue Oct 22, 2021 · 0 comments
Open

Should const $x = $y match const ($x = $y) and vice versa? #295

quasilyte opened this issue Oct 22, 2021 · 0 comments

Comments

@quasilyte
Copy link
Owner

quasilyte commented Oct 22, 2021

Right now it does.
But I think it shouldn't.

Caveat: if we make it non-matching, this pattern should become compileable var ($*_; $v = $_; $*_).
Right now it will fail to compile as it forms an AST that can't be parsed by go/parser.

I'm attaching a patch that could be used as a reference for gendecl () aware matching implementation.

patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant