Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: overcoming srcimporter issues #288

Merged
merged 1 commit into from Oct 19, 2021
Merged

Conversation

quasilyte
Copy link
Owner

See go-critic/go-critic#1126

We're using the host-specific go env info to avoid incorrect
GOROOT and other Go build context variables.

@quasilyte quasilyte force-pushed the quasilyte/hacking_src_importer branch 6 times, most recently from d787677 to b7e08f9 Compare October 19, 2021 09:14
See go-critic/go-critic#1126

We're using the host-specific `go env` info to avoid incorrect
GOROOT and other Go build context variables.
@quasilyte quasilyte force-pushed the quasilyte/hacking_src_importer branch from b7e08f9 to 7f7f4ce Compare October 19, 2021 09:17
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@quasilyte quasilyte merged commit 175420c into master Oct 19, 2021
@quasilyte quasilyte deleted the quasilyte/hacking_src_importer branch October 19, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants