analyzer/testdata: use \Q regexp quoting everywhere
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In analysis test we're using `want` directive to match warnings. I personally thing that 99% of time we need a string matching, not a regexp matching. So this test checks that we do `\Q` escaping everywhere, making our patterns matching string "as is"; so you don't have to escape `(` and `)` in the patterns.
quasilyte
force-pushed
the
quasilyte/fix_testcomments
branch
from
4e27e9d
to
d020369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In analysis test we're using
wantdirective to match warnings.I personally thing that 99% of time we need a string matching,
not a regexp matching. So this test checks that we do
\Qescaping everywhere, making our patterns matching string "as is";
so you don't have to escape
(and)in the patterns.