Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR not working for files directly imported in the router #8534

Closed
2 of 14 tasks
Evertvdw opened this issue Feb 24, 2021 · 3 comments
Closed
2 of 14 tasks

HMR not working for files directly imported in the router #8534

Evertvdw opened this issue Feb 24, 2021 · 3 comments
Labels

Comments

@Evertvdw
Copy link
Contributor

Evertvdw commented Feb 24, 2021

Describe the bug
When starting up a new project (I added Vuex and Typescript, and using Class components FYI) and running the dev server the HMR seems broken for files that are imported in the routes.ts file. So in this case the layouts and pages.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new app as described above.
  2. Startup the dev server'
  3. Add some text to "Index.vue" and save
  4. Check if HMR worked

Expected behavior
HMR should work for all files, also the pages and layouts that are imported in the router.

Platform (please complete the following information):
Quasar Version: v2.0.0-beta.7
@quasar/app Version: v3.0.0-beta.7
Quasar mode:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

Tested on:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

OS: Windows
Node: v12.13.1
NPM: 6.12.1
Yarn: 1.22.4
Browsers: Chrome
iOS:
Android:
Electron:

@Evertvdw Evertvdw added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Feb 24, 2021
@SuspiciousLookingOwl
Copy link

Seems like this is caused by vue-class-component. I had similar issue and after changing the component type to normal options API the HMR started to work

@rstoenescu
Copy link
Member

This is an issue that should be reported to vue-class-component owners, not Quasar.

@Evertvdw
Copy link
Contributor Author

Reported issue at vue-class-component: vuejs/vue-class-component#521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants