Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify usage is out of sync w.r.t to source code #15789

Closed
agebhar1 opened this issue May 4, 2023 · 8 comments
Closed

Notify usage is out of sync w.r.t to source code #15789

agebhar1 opened this issue May 4, 2023 · 8 comments

Comments

@agebhar1
Copy link

agebhar1 commented May 4, 2023

Description

The Notify API and also the 'Basic' example mention the method 'create' which was removed a long time ago at 368667c. The file ui/src/plugins/Notify.js was updated but ui/src/plugins/Notify.json not.

The issue was also mentioned on #14122.

Documentation Section URL

https://quasar.dev/quasar-plugins/notify#basic

Flavour

None

Areas

Plugins (quasar)

@pdanpdan
Copy link
Collaborator

pdanpdan commented May 4, 2023

It was not removed, what do you mean?

@pdanpdan pdanpdan closed this as completed May 4, 2023
@agebhar1
Copy link
Author

agebhar1 commented May 4, 2023

The 'create' method. I forget to mention it.

@pdanpdan
Copy link
Collaborator

pdanpdan commented May 4, 2023

@agebhar1
Copy link
Author

agebhar1 commented May 4, 2023

grafik

@pdanpdan
Copy link
Collaborator

pdanpdan commented May 4, 2023

Ignore that - it is a bug in the conversion to the codepen that must be fixed

@agebhar1
Copy link
Author

agebhar1 commented May 4, 2023

I do, but that's not the issue. This does not work:

Notify.create({
  message: 'Danger, Will Robinson! Danger!'
})

and it's still in the documentation.

@pdanpdan
Copy link
Collaborator

pdanpdan commented May 4, 2023

It works, see updated codepen
Are you sure you installed the plugin?
https://quasar.dev/quasar-plugins/notify#installation

@agebhar1
Copy link
Author

agebhar1 commented May 4, 2023

You're right, it works. My fault. Retried it with a plain project. Last time I might missed to install/register the plugin or something others went wrong. The error was, and if I do not register the plugin it's the same, that 'create is not function' popped up in the error log.

I appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants