Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve QInput.nativeEl and QFile.nativeEl types by narrowing #15128

Closed
yusufkandemir opened this issue Dec 16, 2022 Discussed in #15121 · 1 comment · Fixed by #15129
Closed

Improve QInput.nativeEl and QFile.nativeEl types by narrowing #15128

yusufkandemir opened this issue Dec 16, 2022 Discussed in #15121 · 1 comment · Fixed by #15129
Assignees
@yusufkandemir
Labels
area/typescript kind/feature 💡 Qv2 🔝 Quasar v2 issues

Comments

@yusufkandemir
Copy link
Member

Discussed in #15121

Originally posted by mv-go December 16, 2022
According to docs the type of nativeEl and the return type of getNativeElement is
The native input/textarea DOM Element

However, the typings that shipped with the library suggest that the type here is a very general Element.

Could it be possible to narrow it down to HTMLInputElement | HTMLTextAreaElement? Or are there some edge cases that I'm missing?
@yusufkandemir yusufkandemir self-assigned this Dec 16, 2022
@yusufkandemir yusufkandemir mentioned this issue Dec 16, 2022
Merged
rstoenescu pushed a commit that referenced this issue Dec 17, 2022
@yusufkandemir
feat(ui): Improve QInput and QFile nativeEl types (fix #15128) (#15129)
ee25829 
* feat(ui): Improve QInput.nativeEl types
Also exposing QInputNativeElement type with generics for more flexibility

* feat(ui): Improve QFile.nativeEl types
Also exposing QFileNativeElement type

* feat(ui): Improve QInputNativeElement with file type handling
@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yusufkandemir yusufkandemir

Labels
area/typescript kind/feature 💡 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): Improve QInput and QFile nativeEl types (fix #15128) yusufkandemir/quasar
2 participants
@rstoenescu @yusufkandemir