Skip to content

fix(QIcon): fix QIcon shrink without breaking aspect #12016, #13521 #13651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

pdanpdan
Copy link
Collaborator

@pdanpdan pdanpdan commented Jun 9, 2022

No description provided.

@rstoenescu rstoenescu merged commit b7c061a into quasarframework:dev Jun 16, 2022
@pdanpdan pdanpdan deleted the fix/v2-icon-shrink-aspect branch June 16, 2022 16:47
@Tofandel
Copy link
Contributor

Tofandel commented Jun 21, 2022

This breaks the icons of .q-timeline__dot which have a special styling with width: 100%
Before
image
After
image

Only the case with svg icons

Tofandel added a commit to Tofandel/quasar that referenced this pull request Jun 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes the regression introduced in quasarframework#13651
rstoenescu pushed a commit that referenced this pull request Jun 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes the regression introduced in #13651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants