Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastClick (touchstart) makes double tapping required for Capacitor camera plugin #11582

Closed
MatthewSH opened this issue Dec 7, 2021 · 4 comments
Labels
Qv2 🔝 Quasar v2 issues

Comments

@MatthewSH
Copy link

MatthewSH commented Dec 7, 2021

Describe the bug
FastClick breaks on specific edge cases with capacitor camera. I've spent way too much time tracking this issue down.
If you use Capacitor camera and you build your app for PWA then on the camera modal it requires you double-tap to hit any of the buttons, however no other elements through the entire app have this issue, and it only happens when you add it as a PWA, if you open it in Safari it works completely fine. (which makes sense based on this in client-entry, also the vite version here),

I tracked this down by using Safari web inspector and disabling event listeners after troubleshooting through everything else. Eventually found the culprit (technically it was an "anonymous function" within FastClick but once I added a breakpoint it linked directly to it. Disable that event listener and the modal works just fine, enable it and this bug occurs.

I'm not sure if this has anything to do with the fact that it's Stencil web components for capacitor because of their PWA elements. I don't know what the right answer is and I'm still troubleshooting and trying to find a solution.

Platform (please complete the following information):
Quasar Version: 2.0.4
@quasar/app Version: 3.1.0
@capacitor/core - 3.2.2
@capacitor/camera - 1.0.5


Looks like our versions are a bit out of date, the fastclick files don't look updated, but I'll do a full upgrade on everything and test again, once that is done I'll report back. Other than that, I have no idea.

@MatthewSH MatthewSH added the Qv2 🔝 Quasar v2 issues label Dec 7, 2021
@MatthewSH
Copy link
Author

Update: upgrades our packages and it's still messing up...maybe this is a capacitor/pwa-elements/plugins issue? Want to get input here first.

Quasar: 2.3.4
@quasar/app: 3.2.5
@capacitor/core: 3.3.2
@capacitor/camera: 1.2.1

I'll probably have to do some nasty DOM workaround since I can't remove fastclick, I can't bypass it, the needsclicked doesn't work, etc.

Anyone else experience this?

@jaybo
Copy link

jaybo commented Mar 25, 2022

I seem to be experiencing this issue with mapbox geocoder results within a q-card-section. Only on iOS/PWA the click handler for autocompletion results fails to fire. This link implies that needsclick should to be added to each result:
mapbox/mapbox-gl-geocoder#49 (comment)

Update: Added needsclick as in the referenced link fixed my issue!

@MatthewSH
Copy link
Author

MatthewSH commented Jun 6, 2022

Just want to add a reference to another issue: #13619

@rstoenescu
Copy link
Member

Our fastclick has been removed some time ago. Forgot to close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

3 participants