-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(QIcon): Add check for lowercase 'm' for valid start of svg path #11506
Conversation
Some icon sets work perfectly well with lowercase 'm' and when adding `M0 0z` causes a black dot in upper-left of the icon. In this case, the regex need to be `/^M|m/`
I have tested this with the change in dev and it works perfectly fine. None of the other icon sets were disturbed. |
|
Also, this broke all mdi icons... |
I forgot, this also needs to be done for v1 |
In v1, this seems to cause an issue for |
I am going to re-review this update (into v2) to make sure there is no conflict with |
Fixed it already. And shipped it in latest Quasar |
Hi, I have problems rendering simAmazon on Quasar v.2.3.4
I believe it should be like this to support dots right after first character: |
Of course it was a catch somewhere. |
Fix is also added into v1: #11583 |
Hi, |
@haasz It's coming this week. Next Quasar version is a big one, which is why it's taking a bit more time to be released. |
@rstoenescu Thanks for the reply. |
Some icon sets work perfectly well with lowercase 'm' and when adding
M0 0z
causes a black dot in upper-left of the icon. In this case, the regex needs to be/^M|m/