Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select clearable is not working (on a dialog) #11297

Closed
2 of 14 tasks
ozelotdev opened this issue Nov 12, 2021 · 3 comments
Closed
2 of 14 tasks

select clearable is not working (on a dialog) #11297

ozelotdev opened this issue Nov 12, 2021 · 3 comments
Assignees
@hawkeye64
Labels
Qv2 🔝 Quasar v2 issues

Comments

@ozelotdev
Copy link

Describe the bug
q-select's clearable is not working. (on a dialog)

Codepen/jsFiddle/Codesandbox (required)
Editor: https://codesandbox.io/s/inspiring-stallman-ji8nt?file=/src/pages/Index.vue
Viewer: https://ji8nt.sse.codesandbox.io

To Reproduce

  1. Open the page in mobile view.
  2. Select "Example Selector" (a dialog should appear)
  3. Select some items.
  4. Select the clear button in the upper right corner.
  5. Not working.

Expected behavior
The Clear button shown on the page will work.
The Clear button displayed on a dialog should work the same way.

Screenshots
スクリーンショット 2021-11-12 11 09 16

Platform (please complete the following information):
Quasar Version: v2.3.1
@quasar/app Version: 3.1.0

Quasar mode:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

Tested on:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

OS: Windows 10
Node: v14.18.1
NPM:6.14.15
Yarn:
Browsers: Firefox 94.0.1
iOS:
Android:
Electron:

Additional context
N/A
@ozelotdev ozelotdev added the Qv2 🔝 Quasar v2 issues label Nov 12, 2021
@hawkeye64 hawkeye64 self-assigned this Nov 12, 2021
@hawkeye64
Copy link
Member

@ozelotjp Hi, thanks for finding this! I have been working on it most of the day and have a fix. I just need more testing to make sure there are no side effects with such a large component.

qselect-clearable--mobile--issue.mp4

hawkeye64 added a commit to hawkeye64/quasar that referenced this issue Nov 12, 2021
@hawkeye64
fix(ui): select clearable is not working (on a dialog) quasarframewor…
37bee6e 
…k#11297

The "state.splitAttrs.listeners.value" does not contain the listeners (like it used too. Did Vue make some undocumented changes?) as expected. I added a composable, "use-listeners.js" (quasar had something similar at start of v2). Anyway, it all works now - in a dialog/menu, or stand-alone desktop web page. I create a "dev/selct-mobile" for testing this functionality. You can test before the merge to verify (it's already in dev)
hawkeye64 added a commit to hawkeye64/quasar that referenced this issue Nov 12, 2021
@hawkeye64
fix(ui): select clearable is not working (on a dialog) (quasarframewo…
7d9aa36 
…rk#11297)

The "state.splitAttrs.listeners.value" does not contain the listeners (like it used too. Did Vue make some undocumented changes?) as expected. I added a composable, "use-listeners.js" (quasar had something similar at start of v2). Anyway, it all works now - in a dialog/menu, or stand-alone desktop web page. I create a "dev/selct-mobile" for testing this functionality. You can test before the merge to verify (it's already in dev)
rstoenescu added a commit that referenced this issue Nov 13, 2021
@rstoenescu
fix(ui/split-attrs): update to newest vue specs #11297
cf47248
@rstoenescu
Copy link
Member

This is due to an underlying Vue breaking change.
Updated our code to Vue's latest specs.

Will be available in Quasar v2.3.2.

@ozelotdev
Copy link
Author

Thanks for this and other contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkeye64 hawkeye64

Labels
Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rstoenescu @hawkeye64 @ozelotdev