-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app/icon-genie/docs): more refinement for Electron #11163
Merged
rstoenescu
merged 22 commits into
quasarframework:dev
from
hawkeye64:fix/electron-icons
Nov 13, 2021
Merged
fix(app/icon-genie/docs): more refinement for Electron #11163
rstoenescu
merged 22 commits into
quasarframework:dev
from
hawkeye64:fix/electron-icons
Nov 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, the "linux-512x512.png" is not needed. The file itself should be renamed to "icon.png", which can be used by all platforms for the Tray icon (the others are needed for the embedded icons). But, we don't want to introduce any breaking changes, so if "icon.png" does not exist, we will copy "linux-512x512.png" to "icon.png". Then, in "electron-main.js" only one image file is needed for the tray icon. Additionally, we can fix "quasar-conf-file.js" to prevent the "can't stat 'icons/icon'" that only happens under linux.
This is to support changes in App in regards to "icon.png"
The 'electron-handler.js' file is being introduced to help developers keep their separation-of-concerns out of the 'electron-main.js' file. It keeps things modular and also introduces a 'useElectronHandler()' method, which keeps it comfortable with those familiar with Vue's composition API. This method is an empty function containing commented example code.
14 tasks
rstoenescu
added a commit
that referenced
this pull request
Nov 13, 2021
rstoenescu
added a commit
that referenced
this pull request
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "linux-512x512.png" is not needed. The file itself should be renamed to "icon.png", which can be used by all platforms for the Tray icon (the others are needed for the embedded icons), and seems silly to use "linux-512x512.png" when building for other platforms. But, we don't want to introduce any breaking changes, so if "icon.png" does not exist, we will copy "linux-512x512.png" to "icon.png". Then, in "electron-main.js" only one image file is needed for the tray icon. Additionally, we can fix "quasar-conf-file.js" to prevent the "can't stat 'icons/icon'" that only happens under Linux.
Icon Genie has also been modified to create/update the
electron-src/icons/icon.png
file.Additionally, this PR introduces the
electron-handler.js
script. It is imported byelectron-main
.Here is what
electron-handler
looks like:Basically, it's a best practices ideology for separation-of-concerns where developers can add their
ipcMain
interactions from theelectron-preload
so thatelectron-main
doesn't have to deal with them (especially when you can get into dozens of interactions on a full-fledged Electron app).What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: