-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transpiled modules don't get rebuilt anymore #10260
Comments
This is an external problem and due to webpack changing its behavior. It's not watching node_module deps anymore. |
@rstoenescu but it (mostly) worked with the hotfix i posted here: #10083 (comment) |
Think I found the culprit. |
while hmr is not fixed, it now works after f5. good enough to work with. thank you! |
HMR should work with symlinked deps now. 100%. Only thing that comes to my mind is you're prolly developing a PWA? In which case: https://quasar.dev/quasar-cli/developing-pwa/hmr-for-dev#introduction |
Describe the bug
modules (from
node_modules
folder) which are transpiled usingtranspileDependencies
andtranspile
options inquasar.conf.js
were previously watched for changes and if changes to those modules occurred, the quasar app (spa in my case) would rebuild and directly apply the changes. this can be useful, if you want to link your dependency and develop it within a quasar app, e. g. vianpm link my-dependency
. i used this for some years now.but recently i noticed it doesn't work anymore. there are no errors in the console and the change still appears to be detected. it even looks like it's rebuilding the app (judging by console), but the app never updates the changed part. only restarting the development server (
quasar dev
) helps, or changing some prop inquasar.conf.js
which triggers the whole app to be rebuilt.this is a major blocker for any development involving (linked) dependencies.
Codepen/jsFiddle/Codesandbox (required)
i don't think this can be shown on codepen, sorry.
To Reproduce
Steps to reproduce the behavior:
npm link my-dependency
in quasar folder)transpileDependencies
and settranspile
option totrue
inquasar.conf.js
quasar dev
.vue
files)Expected behavior
change should be applied, just as if the dependency was a part of the source code
Platform (please complete the following information):
Quasar Version: 2.0.3
@quasar/app Version: 3.0.3
Quasar mode:
Tested on:
OS: linux (someone i know could reproduce the issue in windows)
Node: 16 (also tested 14, no difference)
NPM: 7 (also tested 6 - i believe -, no difference)
Yarn:
Browsers:
iOS:
Android:
Electron:
Additional context
I also tried downgrading node, which didn't help. I also tried downgrading the two quasar packages to some betas, which didn't help either.
i think this problem is different from the other one, because it only affects modules and i have no console errors. other one: #10083
i also believe this problem isn't directly about linking, because normal (unlinked) dependencies show the same issues when changed.
The text was updated successfully, but these errors were encountered: