We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug A trailing comma in a quasar import statement results in build failure.
Codepen/jsFiddle/Codesandbox (required) https://github.com/tvkit/quasar-comma-bug
To Reproduce clone, yarn, and run quasar dev
Expected behavior successful build
Screenshots
Platform (please complete the following information): Quasar Version: 2.0.2 @quasar/app Version: 3.0.2
Quasar mode:
Tested on:
OS: Windows 10 Node: 12.22.1 NPM: 6.14.12 Yarn: 1.22.5 Browsers: n/a iOS: n/a Android: n/a Electron: n/a
Additional context
A new quasar-generated project was created to demonstrate the behavior.
This results in failure: import { QTable, useQuasar, } from 'quasar';
import { QTable, useQuasar, } from 'quasar';
This does not: import { QTable, useQuasar } from 'quasar';
import { QTable, useQuasar } from 'quasar';
A pesky vs-code extension insisted on the trailing comma. I've since removed the extension.
The text was updated successfully, but these errors were encountered:
This would be a result of whatever linter you are using and how the rules are set up.
Sorry, something went wrong.
@hawkeye64
Not a linter violation, but a compilation failure.
The issue is likely caused by an empty identifier on the following comma split:
quasar/app/lib/webpack/loader.js.transform-quasar-imports.js
Line 9 in 78df1f4
@tvkit Good catch, since trailing commas are legal and quite common in JavaScript.
fix(app): correctly transform imports from Quasar (trailing comma iss…
5f59bda
…ue) #10049
Fix will be available in "@quasar/app" v3.1.7. This does not happen for non-TS though.
No branches or pull requests
Describe the bug
A trailing comma in a quasar import statement results in build failure.
Codepen/jsFiddle/Codesandbox (required)
https://github.com/tvkit/quasar-comma-bug
To Reproduce
clone, yarn, and run quasar dev
Expected behavior
successful build
Screenshots
Platform (please complete the following information):
Quasar Version: 2.0.2
@quasar/app Version: 3.0.2
Quasar mode:
Tested on:
OS: Windows 10
Node: 12.22.1
NPM: 6.14.12
Yarn: 1.22.5
Browsers: n/a
iOS: n/a
Android: n/a
Electron: n/a
Additional context
A new quasar-generated project was created to demonstrate the behavior.
This results in failure:
import { QTable, useQuasar, } from 'quasar';
This does not:
import { QTable, useQuasar } from 'quasar';
A pesky vs-code extension insisted on the trailing comma. I've since removed the extension.
The text was updated successfully, but these errors were encountered: