Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SimpleThreadPool from examples? #1230

Closed
barsv opened this issue Jun 24, 2021 · 1 comment · Fixed by #1262
Closed

Remove SimpleThreadPool from examples? #1230

barsv opened this issue Jun 24, 2021 · 1 comment · Fixed by #1262
Milestone
3.3.3

Comments

@barsv
Copy link
Contributor

barsv commented Jun 24, 2021

Minor thing. I see in examples in several places ["quartz.threadPool.type"] = "Quartz.Simpl.SimpleThreadPool, Quartz", Should it be removed from examples if SimpleThreadPool was removed in v.3.0?
@lahma
Copy link
Member

lahma commented Jul 28, 2021

Yes generally it doesn't make sense to show the option of type as it's usually the default. I would welcome a PR to update the docs / and or the examples.

@lahma lahma mentioned this issue Jul 31, 2021
Merged
@lahma lahma added this to the 3.3.3 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.3
Development

Successfully merging a pull request may close this issue.

Tweak scheduler building API and remove reference to SimpleThreadPool quartznet/quartznet
2 participants
@lahma @barsv