Use custom InstantiateType for all instantiations in StdSchedulerFactory #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use InstantiateType that can be overloaded to allow custom instantiation of plugins, job listeners and trigger listeners. When used with Quartz.AspNetCore, it will allow to use dependency injection in plugins and other types.
|
I have no idea whiy that test is failed. On my local machine, it and many ither tests failed even without changes. |
|
It's not the most rewarding thing trying to have CI system for a threaded / timing critical library 😄 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use InstantiateType that can be overloaded to allow custom instantiation of plugins, job listeners and trigger listeners. When used with Quartz.AspNetCore, it will allow to use dependency injection in plugins and other types.