Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regular AddJob Type #1090

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add a regular AddJob Type #1090

merged 2 commits into from
Jan 27, 2021

Conversation

startewho
Copy link
Contributor

When I want to dynicmic add a Job ,it ususally use the reflection.so i add a regular AddJob method .

lahma
lahma requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR! Please have a look at my comment.

src/Quartz.Extensions.DependencyInjection/ServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
@startewho startewho requested a review from lahma January 27, 2021 09:31
@lahma lahma merged commit a12a80b into quartznet:main Jan 27, 2021
@lahma lahma added this to the 3.3 milestone Jan 27, 2021
@lahma
Copy link
Member

lahma commented Jan 27, 2021

Thank you for your contribution!

@lahma lahma mentioned this pull request Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@startewho @lahma