Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB/flash clear/save behavior w.r.t. default changes #861

Open
jordens opened this issue Mar 27, 2024 · 2 comments · May be fixed by #884
Open

USB/flash clear/save behavior w.r.t. default changes #861

jordens opened this issue Mar 27, 2024 · 2 comments · May be fixed by #884
Milestone

Comments

@jordens
Copy link
Member

jordens commented Mar 27, 2024

Once things have been saved to flash (also implicitly through e.g. clear), then changes in Default are not propagated. This makes the behavior with an empty flash (that has never seen clear) different from the one after clear. Usual expectation is that clear restores behavior to "what it was before/initially", arguably including transparent propagation/activation of changes to Default with app updates.

The proposed alternative is to use remove_item in current clear and #860

#857 (comment)

@ryan-summers
Copy link
Member

ryan-summers commented Mar 27, 2024

@jordens Based on my understanding, if you change a Default in the application and re-run the clear command, you will receive the new Default value. Is this specifically what is not desired?

I'm not entirely seeing the difference between an uninitialized flash and one that is cleared. Yes, it will have initial values in it that may or may not be Default, but the proposed change to use remove_item and the current implementation wouldn't have any different effect on the clear command or operation of the device.

@jordens
Copy link
Member Author

jordens commented Mar 27, 2024

I'd see the additional clear required as an work around.

The behavior is different. With the proposed change clear followed by app update also updates to new defaults (like sucessive app updates without ever touching USB).

@jordens jordens added this to the 0.10 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants