Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to save active settings to flash #859

Open
ryan-summers opened this issue Mar 27, 2024 · 1 comment · Fixed by #872
Open

Add ability to save active settings to flash #859

ryan-summers opened this issue Mar 27, 2024 · 1 comment · Fixed by #872
Assignees
Milestone

Comments

@ryan-summers
Copy link
Member

Add functionality to save the currently-operational settings into device flash memory via the USB interface. This was identified in #857 (comment)

@jordens
Copy link
Member

jordens commented Apr 24, 2024

When playing with it I noticed that after the change to a shared settings struct the behavior is not anymore (after the very positive changes to shared settings) what I'd have expected (without reading docs/code).

  • set saves "everything" (in the sense that what is doesn't save is unchanged from default). At least now it should save only what's been set. But arguably it should not save at all anymore (since it already affects live application settings).
  • There is no way to "save the settings to flash" without actively setting one. Since over USB we now share the MQTT view, I'd want a save command to make the currently active (and visible) settings the initial settings.

I think I closed this too early.

@jordens jordens reopened this Apr 24, 2024
@jordens jordens added this to the 0.10 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants