Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluate ETH DMA design #84

Open
jordens opened this issue Mar 8, 2020 · 4 comments
Open

evaluate ETH DMA design #84

jordens opened this issue Mar 8, 2020 · 4 comments
Labels
maintenance

Comments

@jordens
Copy link
Member

jordens commented Mar 8, 2020 •
edited

Use VolatileCell along the lines of stb32-usbd and check what evolves around best practices of DMA/uninit, (MaybeUninit, compiler_fence).
@ryan-summers
Copy link
Member

@jordens I believe this can be closed since we're using stm32h7-ethernet

@jordens
Copy link
Member Author

jordens commented Jun 16, 2020

I don't think so. stm32h7-ethernet doesn't mark the descriptors as VolatileCells either. It doesn't differ from my old code in that respect AFAICT.

@ryan-summers
Copy link
Member

ryan-summers commented Jun 16, 2020 •
edited

What I mean is that this issue isn't necessary suitable for this repository anymore, but rather the linked stm32h7x-ethernet crate since we don't implement any ethernet DMA functionality here after the HAL refactor.

@jordens
Copy link
Member Author

jordens commented Jun 16, 2020

Oh yes. Right. Somebody with a sound understanding of this should move it over to stm32h7-ethernet if appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordens @ryan-summers