Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review DelayUs/DelayMs API and possible migrate away. #591

Open
jordens opened this issue Aug 9, 2022 · 0 comments
Open

Review DelayUs/DelayMs API and possible migrate away. #591

jordens opened this issue Aug 9, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@jordens
Copy link
Member

jordens commented Aug 9, 2022

#590 (review)

We should try to get away from DelayUs/DelayMs at some point in the future. The API is an invitation for error: Into<u32> strips units, granularity, and context as delay_us(something.into()) looks just as good (but is wrong) if something.into::<u32>() are actually ms.
It does seem like we should leverage as much as possible from fugit.
@jordens jordens added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordens