Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have some light-mode content on the front page? #1980

Open
holly-cummins opened this issue May 16, 2024 · 2 comments · May be fixed by #1983
Open

Should we have some light-mode content on the front page? #1980

holly-cummins opened this issue May 16, 2024 · 2 comments · May be fixed by #1983

Comments

@holly-cummins
Copy link
Contributor

If I'm on http://quarkus.io and I change the dark mode toggle, nothing on the page changes. That's consistent with the design, but it makes it look like the toggle isn't working. I wonder if something on the page should be light mode, so that users get visual feedback on the toggle? (I got confused and thought I'd broken something because I had a sun image and dark content, but it was just that the whole page is always dark.)

cc @insectengine

@insectengine
Copy link
Contributor

This is an artifact of the original move from a dark website to a light website. There was concern of the change could potentially be off putting for the users so as a compromise in keeping the home page. At this point, I'd say we scrap this approach and make light /dark versions of the home page that works like the rest of the site.

@insectengine insectengine linked a pull request May 17, 2024 that will close this issue
@insectengine
Copy link
Contributor

Resolves this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants