Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next: provide strategies to process unhandled failures #40655

Merged
merged 1 commit into from
May 16, 2024
Merged

WebSockets Next: provide strategies to process unhandled failures #40655

merged 1 commit into from
May 16, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 15, 2024 •
edited

We provide the following strategies:

  1. Close the connection (default)
  2. Log an error message
  3. NOOP

@mkouba mkouba force-pushed the issue-40648 branch 3 times, most recently from cd26f0f to 2880cb8 Compare May 15, 2024 18:07
@mkouba mkouba marked this pull request as ready for review May 15, 2024 18:07
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
WebSockets Next: provide strategies to process unhandled failures
faf0d36 
- resolves quarkusio#40648
- also add WebSocketConnection#closeReason() and
  WebSocketClientConnection#closeReason()
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation May 16, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2024 •
edited by github-actions bot

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit faf0d36.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit faf0d36.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

🙈 The PR is closed and the preview is expired.

Quarkus Documentation automation moved this from To do to Reviewer approved May 16, 2024
@mkouba mkouba merged commit 8402d10 into quarkusio:main May 16, 2024
22 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done May 16, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 16, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label May 16, 2024
@sberyozkin
Copy link
Member

Thanks @mkouba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@geoand geoand geoand approved these changes

@michalvavrik michalvavrik michalvavrik approved these changes

@cescoffier cescoffier Awaiting requested review from cescoffier

@sberyozkin sberyozkin Awaiting requested review from sberyozkin

Assignees
No one assigned
Labels
area/documentation kind/enhancement New feature or request
Projects
Quarkus Documentation
Done
Milestone
3.12 - main
Development

Successfully merging this pull request may close these issues.

WebSockets Next: provide strategies to process unhandled failures
5 participants
@mkouba @sberyozkin @stuartwdouglas @geoand @michalvavrik