Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubernetes client split package check #39300

Open
shawkins opened this issue Mar 8, 2024 · 6 comments
Open

Remove kubernetes client split package check #39300

shawkins opened this issue Mar 8, 2024 · 6 comments
Labels
area/arc Issue related to ARC (dependency injection) area/kubernetes

Comments

@shawkins
Copy link
Contributor

shawkins commented Mar 8, 2024

should no longer be necessary with newer client versions.

cc @manusa

@yrodiere yrodiere added area/arc Issue related to ARC (dependency injection) area/kubernetes and removed triage/needs-triage labels Mar 11, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 11, 2024

/cc @Ladicek (arc), @geoand (knative,kubernetes,minikube,openshift), @iocanel (knative,kubernetes,openshift), @manovotn (arc), @mkouba (arc)

@geoand geoand changed the title Remove kuberentes client split package check Remove kubernetes client split package check Mar 11, 2024
@geoand
Copy link
Contributor

geoand commented Mar 11, 2024

I don't really follow the updates in the k8s client that closely, so I'll leave this up to you.

@geoand
Copy link
Contributor

geoand commented Mar 11, 2024

In that case, feel free to remove the check mentioned in the description of the issue

@Dairdevil
Copy link

Does it make sense to change the predicate to:

public boolean test(String packageName) {
            return false;
 }

and maintain the ignore functionality in case it is needed again in future? Or would it be better to strip all that out now?

@manovotn
Copy link
Contributor

I'd just remove it.
If we need it again, we can re-add that functionality although IIRC the idea was that the split package issues will once be resolved and we will remove these checks altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/kubernetes
Projects
None yet
Development

No branches or pull requests

6 participants