Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13.0 backports 1 #28103

Merged
merged 49 commits into from Sep 20, 2022
Merged

2.13.0 backports 1 #28103

merged 49 commits into from Sep 20, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 20, 2022

Please don't merge, I will merge it myself.

reda-alaoui and others added 30 commits September 20, 2022 18:38
The truststore password was being sent as empty ("") in the JksOptions. This caused the following exception:

```
Caused by: io.vertx.core.VertxException: java.security.UnrecoverableKeyException: Get Key failed: Given final block not properly padded. Such issues can arise if a bad key is used during decryption.
[09:59:27.352] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:480)
[09:59:27.353] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:469)
[09:59:27.353] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.validate(SSLHelper.java:507)
[09:59:27.353] [INFO] [client]  at io.vertx.core.net.impl.NetClientImpl.<init>(NetClientImpl.java:95)
[09:59:27.353] [INFO] [client]  at io.vertx.core.http.impl.HttpClientImpl.<init>(HttpClientImpl.java:155)
[09:59:27.354] [INFO] [client]  at io.vertx.core.impl.VertxImpl.createHttpClient(VertxImpl.java:338)
[09:59:27.354] [INFO] [client]  at io.vertx.core.impl.VertxImpl.createHttpClient(VertxImpl.java:350)
[09:59:27.354] [INFO] [client]  at org.jboss.resteasy.reactive.client.impl.ClientImpl.<init>(ClientImpl.java:170)
[09:59:27.354] [INFO] [client]  at org.jboss.resteasy.reactive.client.impl.ClientBuilderImpl.build(ClientBuilderImpl.java:244)
[09:59:27.354] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientBuilderImpl.build(RestClientBuilderImpl.java:332)
[09:59:27.355] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.build(RestClientCDIDelegateBuilder.java:64)
[09:59:27.355] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.createDelegate(RestClientCDIDelegateBuilder.java:42)
[09:59:27.355] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientReactiveCDIWrapperBase.<init>(RestClientReactiveCDIWrapperBase.java:20)
[09:59:27.355] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper.<init>(Unknown Source)
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_ClientProxy.<init>(Unknown Source)
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_Bean.proxy(Unknown Source)
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_Bean.get(Unknown Source)
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_Bean.get(Unknown Source)
[09:59:27.357] [INFO] [client]  ... 26 more
[09:59:27.357] [INFO] [client] Caused by: java.security.UnrecoverableKeyException: Get Key failed: Given final block not properly padded. Such issues can arise if a bad key is used during decryption.
[09:59:27.357] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:446)
[09:59:27.357] [INFO] [client]  at java.base/sun.security.util.KeyStoreDelegator.engineGetKey(KeyStoreDelegator.java:90)
[09:59:27.357] [INFO] [client]  at java.base/java.security.KeyStore.getKey(KeyStore.java:1057)
[09:59:27.357] [INFO] [client]  at io.vertx.core.net.impl.KeyStoreHelper.<init>(KeyStoreHelper.java:109)
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.KeyStoreOptionsBase.getHelper(KeyStoreOptionsBase.java:187)
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.KeyStoreOptionsBase.getTrustManagerFactory(KeyStoreOptionsBase.java:217)
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getTrustMgrFactory(SSLHelper.java:327)
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:478)
[09:59:27.358] [INFO] [client]  ... 43 more
[09:59:27.359] [INFO] [client] Caused by: javax.crypto.BadPaddingException: Given final block not properly padded. Such issues can arise if a bad key is used during decryption.
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.CipherCore.unpad(CipherCore.java:975)
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.CipherCore.fillOutputBuffer(CipherCore.java:1056)
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:853)
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.PKCS12PBECipherCore.implDoFinal(PKCS12PBECipherCore.java:408)
[09:59:27.360] [INFO] [client]  at java.base/com.sun.crypto.provider.PKCS12PBECipherCore$PBEWithSHA1AndDESede.engineDoFinal(PKCS12PBECipherCore.java:440)
[09:59:27.360] [INFO] [client]  at java.base/javax.crypto.Cipher.doFinal(Cipher.java:2202)
[09:59:27.360] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore.lambda$engineGetKey$0(PKCS12KeyStore.java:387)
[09:59:27.360] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore$RetryWithZero.run(PKCS12KeyStore.java:283)
[09:59:27.360] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:381)
[09:59:27.361] [INFO] [client]  ... 50 more
```

(cherry picked from commit b653c64)
This allows for users to configure their filters
via the usual Quarkus configuration approach.

Follows up on: quarkusio#27864

(cherry picked from commit a03cda3)
(cherry picked from commit 80b2553)
(cherry picked from commit 8223153)
(cherry picked from commit fa7319e)
(cherry picked from commit 20bbc7f)
…sing virtual threads

Co-authored-by: Georgios Andrianakis <geoand@gmail.com> and Clément Escoffier <clement.escoffier@redhat.com>
(cherry picked from commit 7270dc6)
(cherry picked from commit 414519c)
(cherry picked from commit 4de0860)
(cherry picked from commit 7164593)
…method with a primitive return type

Relates to: quarkusio#27959

(cherry picked from commit 0932079)
(cherry picked from commit 12802b2)
(cherry picked from commit 80e4125)
(cherry picked from commit a36a99c)
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
(cherry picked from commit 4753afb)
- remove the transient dependent instance from the parent creational
context when the invocation completes
- fixes quarkusio#27906

(cherry picked from commit bcffcb4)
mkouba and others added 6 commits September 20, 2022 18:42
- if no other qualifier is declared then @Any is used, i.e. the behavior
should be equivalent to `@Inject @Any Instance<>`

(cherry picked from commit 492b29c)
(cherry picked from commit b944209)
(cherry picked from commit 7d2c53c)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Sep 20, 2022
@gsmet gsmet self-assigned this Sep 20, 2022
@quarkus-bot quarkus-bot bot added area/agroal area/arc Issue related to ARC (dependency injection) area/codestarts area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/funqy area/jackson Issues related to Jackson (JSON library) area/keycloak area/logging area/maven area/narayana Transactions / Narayana area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/resteasy-reactive area/spring Issues relating to the Spring integration area/vertx labels Sep 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2022

Failing Jobs - Building 9c1c180

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc-code-flow 

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowTest.testTokenRefresh line 447 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <200> but was: <401>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@gsmet gsmet merged commit 73f5a5f into quarkusio:2.13 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/arc Issue related to ARC (dependency injection) area/codestarts area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/funqy area/infra internal and infrastructure related issues area/jackson Issues related to Jackson (JSON library) area/keycloak area/logging area/maven area/narayana Transactions / Narayana area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/resteasy-reactive area/spring Issues relating to the Spring integration area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet