Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-redis-client: 'fromCoordinate(double, double)' has private access in 'io.quarkus.redis.datasource.geo.GeoSearchArgs' blocking my usage of geosearch FROMLONLAT #27913

Closed
iedwin opened this issue Sep 14, 2022 · 4 comments · Fixed by #27916
Labels
area/redis kind/bug Something isn't working
Milestone

Comments

@iedwin
Copy link

iedwin commented Sep 14, 2022

Describe the bug

According to the manual of Redis geosearch command, it supports to calculate the nearist points from the given longitude and latitude as below. However when I want to use this command via quarkus-redis-client, I found the GeoSearchArgs.fromCoordinate() had private access thus I couldn't use it in my code. I believe this method should have public access as the same as GeoSearchArgs.fromMember().

GEOSEARCH key <FROMMEMBER member | FROMLONLAT longitude latitude>
<BYRADIUS radius <M | KM | FT | MI> | BYBOX width height <M | KM |
FT | MI>> [ASC | DESC] [COUNT count [ANY]] [WITHCOORD] [WITHDIST]
[WITHHASH]

Expected behavior

GeoSearchArgs.fromCoordinate() should have public access as the same as GeoSearchArgs.fromMember().

Actual behavior

GeoSearchArgs.fromCoordinate() has private access so I cannot use geosearch FROMLONLAT.

How to Reproduce?

n/a

Output of uname -a or ver

Linux a176656f74a6 5.4.0-117-generic

Output of java -version

openjdk version "17.0.4" 2022-07-19

GraalVM version (if different from Java)

OpenJDK 64-Bit Server VM GraalVM CE 22.2.0 (build 17.0.4+8-jvmci-22.2-b06, mixed mode, sharing)

Quarkus version or git rev

2.12.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

mavem 3.8.6

Additional information

No response

@iedwin iedwin added the kind/bug Something isn't working label Sep 14, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2022

/cc @cescoffier, @gsmet, @machi1990

@iedwin
Copy link
Author

iedwin commented Sep 14, 2022

hi @cescoffier , I saw you added a backport label on your fix. I am not quite familiar with the merging/backport procedure but I just wonder when I can get the fix envolved version? 2.12.3.Final in the next week?

@gsmet
Copy link
Member

gsmet commented Sep 14, 2022

My plan is to release 2.12.3.Final next Tuesday. It will contain this fix.

@iedwin
Copy link
Author

iedwin commented Sep 14, 2022

My plan is to release 2.12.3.Final next Tuesday. It will contain this fix.

Got it, thanks for your quick reply!

@iedwin iedwin closed this as completed Sep 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 14, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.12.3.Final Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants