kafka-panache-reactive-quickstart fails after #27802

[rsvoboda]

Describe the bug

kafka-panache-reactive-quickstart fails after #27802 got merged, CC @ozangunalp

#27802 is breaking change and there is no information in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.13

Proposal:

• update Migration-Guide-2.13
• indicate which class could use @ActivateRequestContext to fix the trouble
  (Assuming that we really need @ActivateRequestContext)

Error I receive is

2022-09-12 15:39:32,734 ERROR [io.sma.rea.mes.provider] (vert.x-eventloop-thread-4) SRMSG00201: Error caught while processing a message: javax.enterprise.context.ContextNotActiveException: RequestScoped context was not active when trying to obtain a bean instance for a client proxy of PRODUCER_METHOD bean [class=io.quarkus.hibernate.reactive.runtime.ReactiveSessionProducer, id=37346551fd6c9e87c80f25842d68c2d902107673]
	- you can activate the request context for a specific method using the @ActivateRequestContext interceptor binding
	at io.quarkus.arc.impl.ClientProxies.getDelegate(ClientProxies.java:53)

I can get the test passing when I adjust https://github.com/quarkusio/quarkus-quickstarts/blob/main/kafka-panache-reactive-quickstart/src/main/java/org/acme/panache/PriceStorage.java#L15 but the QS is small so it was easy to find the right class and method to annotate

--- a/kafka-panache-reactive-quickstart/src/main/java/org/acme/panache/PriceStorage.java
+++ b/kafka-panache-reactive-quickstart/src/main/java/org/acme/panache/PriceStorage.java
@@ -6,12 +6,14 @@ import io.smallrye.reactive.messaging.annotations.Blocking;
 import org.eclipse.microprofile.reactive.messaging.Incoming;

 import javax.enterprise.context.ApplicationScoped;
+import javax.enterprise.context.control.ActivateRequestContext;
 import javax.transaction.Transactional;

 @ApplicationScoped
 public class PriceStorage {

     @Incoming("prices")
+    @ActivateRequestContext
     Uni<Void> store(int priceInUsd) {
         Price price = new Price();
         price.value = priceInUsd;

Expected behavior

Tests pass

Actual behavior

Tests fail

How to Reproduce?

• clone https://github.com/quarkusio/quarkus-quickstarts
• run mvn clean verify -pl kafka-panache-reactive-quickstart

Output of uname -a or ver

macOS Monterey

Output of java -version

Java 17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

Quarkus main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @FroMage, @alesj, @cescoffier, @loicmathieu, @ozangunalp

[cescoffier]

It's actually a bug fix. It was not really working... it was using the request scope from the application startup.

[rsvoboda]

I'm not proposing to revert it;)

I want to have it documented in migration guide as it's a breaking change

And if possible to indicate which class could use @ActivateRequestContext so the end users can fix their code a bit faster

[rsvoboda]

(I will proceed with QS fix in the meantime)

PR: quarkusio/quarkus-quickstarts#1174

[cescoffier]

I've asked Ozan to add a note (it should have been done while merging)

[ozangunalp]

I've missed that.
@rsvoboda thanks for the heads up, I'll update the migration guide accordingly.

Too bad the error message doesn't mention the channel name. I'll also look into it.

[ozangunalp]

I think we can close this

• Quickstart fixed Add @ActivateRequestContext to start a request scope explicitly quarkus-quickstarts#1174
• 2.13 Migration guide updated : https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.13
• Descriptive logging fixed : Add method as string to message processing exception smallrye/smallrye-reactive-messaging#1889

[rsvoboda]

When is 3.20.0 planned for release? And will it make it into Quarkus 2.13 branch?

When closing issue we should probably set milestone, first 2 items are covered for 2.13.
So should be the milestone set to 2.13? @cescoffier can you give a hint?

[ozangunalp]

I'll try to open the version bump PR this week for 3.19.0 but it doesn't include the last item.
3.20.0 should follow shortly. But I don't know which Quarkus milestone it'll correspond.

[cescoffier]

That issue should be closed.
3.20.0 log fix is nice to have, but not something required.