Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark quarkus:go-offline Maven mojo as thread-safe #27596

Closed
knutwannheden opened this issue Aug 30, 2022 · 2 comments · Fixed by #27600
Closed

Mark quarkus:go-offline Maven mojo as thread-safe #27596

knutwannheden opened this issue Aug 30, 2022 · 2 comments · Fixed by #27600
Labels
area/maven kind/enhancement New feature or request
Milestone

Comments

@knutwannheden
Copy link
Contributor

Description

We are using the quarkus:go-offline goal to pre-populate the local Maven repo in our CI builds. We have then configured GitLab to cache this Maven repo. Now, we would like to execute this Maven build in parallel (something like mvn dependency:go-offline io.quarkus:quarkus-maven-plugin::go-offline -T8 -Dmaven.artifact.threads=4). This works, but we see warnings like this printed to the console:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but this         *
[WARNING] * project contains the following plugin(s) that have goals not  *
[WARNING] * marked as thread-safe to support parallel execution.          *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against Apache Maven.                           *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked as thread-safe in Gluon - Integration Tests - User Context:
[WARNING]   io.quarkus:quarkus-maven-plugin:2.12.0.Final

Assuming that the go-offline goal is thread-safe already, it would only be a matter of changing @Mojo(name = "go-offline") to `@Mojo(name = "go-offline", threadSafe = true).

Implementation ideas

If the mojo is thread-safe, I could provide a PR.

@knutwannheden knutwannheden added the kind/enhancement New feature or request label Aug 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2022

/cc @quarkusio/devtools

@knutwannheden
Copy link
Contributor Author

/cc @aloubyansky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maven kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants