Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing artifacts when running re-augmentation for a mutable application #27546

Closed
pedroigor opened this issue Aug 26, 2022 · 4 comments · Fixed by #27604
Closed

Allow removing artifacts when running re-augmentation for a mutable application #27546

pedroigor opened this issue Aug 26, 2022 · 4 comments · Fixed by #27604
Labels
area/core kind/enhancement New feature or request
Milestone

Comments

@pedroigor
Copy link
Contributor

pedroigor commented Aug 26, 2022

Description

It is possible to remove artifacts from the final application by setting the quarkus.class-loading.removed-artifacts property.

However, this property does not work for mutable applications when running re-augmentation.

This RFE is about taking into account the artifacts set to the quarkus.class-loading.removed-artifacts when re-augmenting a mutable application.

The driven use case is FIPS support in Keycloak. We have two distinct modules offering crypto capabilities. Both should be included (as well as its dependencies) in the distribution but only one of them should be available at runtime.

One of the modules provide our default crypto provider which relies on BC. The other offers FIPS support based on BCFIPS.

When users want to enable FIPS, they should install the corresponding BC jars to a specific directory into the server distribution and, during re-augmentation, we need to remove the default crypto provider and related dependencies from the runtime.

Implementation ideas

Please, see pedroigor@08aa390.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2022

@pedroigor
Copy link
Contributor Author

@gsmet @aloubyansky Thanks a lot. Is there a chance to have it backported to 2.12 ?

@gsmet
Copy link
Member

gsmet commented Aug 31, 2022

I'm not overly excited about it but I will let @aloubyansky judge of that. I don't think we have that many users of this feature and it looks relatively safe.

@aloubyansky
Copy link
Member

I added the backport label to the PR.

@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants