2.7.3 backports 2 #24043
Merged
2.7.3 backports 2 #24043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes quarkusio#23966 (cherry picked from commit ec4e267)
Fixes quarkusio#23988 (cherry picked from commit ec4c30c)
This PR the following issues: - The generated `config-autoscaler` configmap does not set the namespace which should always be `knative-serving` (see for example https://knative.dev/docs/serving/autoscaling/scale-to-zero/#enable-scale-to-zero). - Some properties do add the annotations at Knative service metadata level, and it should add them at Knative service spec template metadata level. - The property `quarkus.knative.global-auto-scaling.containerConcurrency` (hard limit option) wrongly uses the `config-autoscaler` configmap and it should use `config-defaults` configmap (see https://knative.dev/docs/serving/autoscaling/concurrency/#hard-limit) Moreover, add the autoscaling Knative properties to the Knative documentation. Fix quarkusio#23786 (cherry picked from commit 3f797dc)
…active fixes quarkusio#23986 (cherry picked from commit 8efb2f7)
…jo execution in case Maven extensions are disabled (cherry picked from commit 3c454d5)
Fixes quarkusio#23991 (cherry picked from commit ad36396)
Fixes quarkusio#23813 (cherry picked from commit 0fd7b0d)
…evel I only exposed the constraint one and not the custom violation one as I think it is bad practice to globally change the custom violation one. Fix quarkusio#23838 (cherry picked from commit 780d683)
(cherry picked from commit 51bf193)
- follows up on quarkusio#16483 (cherry picked from commit 1e121d3)
(cherry picked from commit 895f043)
quarkus-bot
bot
added
area/devtools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge, I will merge it myself.